Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix pwa-optimized badge gauge #6670

Merged
merged 1 commit into from
Nov 28, 2018
Merged

report: fix pwa-optimized badge gauge #6670

merged 1 commit into from
Nov 28, 2018

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Nov 28, 2018 •
edited
Loading

part of #6395

@exterkamp noticed that a report completing just the PWA Optimized group was getting a blank gray badge gauge.

screen shot 2018-11-27 at 17 14 46

This fixes it to get the proper N/A gauge as specced.

screen shot 2018-11-27 at 17 11 38

@brendankenny brendankenny mentioned this pull request Nov 28, 2018
Closed
31 tasks
exterkamp
exterkamp approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! ❤️

@brendankenny brendankenny merged commit e25e815 into master Nov 28, 2018
@brendankenny brendankenny deleted the optline branch November 28, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exterkamp exterkamp exterkamp approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendankenny @patrickhulce @exterkamp